Exit with non-zero when autofix not applied#552
Open
soraxas wants to merge 1 commit intoInstagram:mainfrom
Open
Exit with non-zero when autofix not applied#552soraxas wants to merge 1 commit intoInstagram:mainfrom
soraxas wants to merge 1 commit intoInstagram:mainfrom
Conversation
Signed-off-by: Tin Lai <tin@tinyiu.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #409
This PR improves the exit code handling in the
fixcommand when multiple issues are encountered in a single run.fixcommand insrc/fixit/cli.pyto set exit codes more accurately: now, exit code2is set for syntax errors, exit code1for unfixable violations, and both are combined to 3 if both types of issues are present. This ensures that the CLI communicates the exact result of the operation.Test Plan
test_fix_exit_codesto verify the exit codes for unfixable violations, syntax errors, and scenarios where both occur together.